[PEPr] Comment on Gtk2 Components::Gtk2_PHPConfig
| From: | Christian Weiske | Date: | Sun, 22 Jan 2006 17:10:27 +0000 |
| Subject: | [PEPr] Comment on Gtk2 Components::Gtk2_PHPConfig | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41031@lists.php.net to get a copy of this message | ||
Christian Weiske (http://pear.php.net/user/cweiske) has commented on the proposal for Gtk2
Components::Gtk2_PHPConfig.
Comment:
I couldn't test it yet, but some notes:
- The package file isn't valid. I get the following:
cweiske:~> pear5 install /data/download/Gtk2_PHPConfig-0.4.tgz
Invalid tag order in <package>, found <> expected one of "usesrole,
usestask, providesextension, srcpackage, srcuri, phprelease,
extsrcrelease, extbinrelease, bundle"
- Since it's a GUI tool, it should provide some method to load a file via
GUI and not only via command line
- The quit method should provide a way to cancel the closing process via
"Yes/No/Cancel" instead of yes/no only.
- It would be nice if the ini structure could be kept, including all of
the comments. I personally hate it if I edit my config files with a
graphical tool, but loose all the comments I made by hand.
- Don't hard-code the "NEW" file name but use a constant. Better use NULL,
as a file may be named "NEW"
- I don't know where DomDocument looks for files, but it seems to me as if
it's only the current working directory. Use dirname(__FILE__) to determine
the file directory.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=346
--
Sent by PEPr, the automatic proposal system at http://pear.php.net