[PEPr] Comment on Gtk2 Components::Gtk2_PHPConfig

Scott Mattocks (http://pear.php.net/user/scottmattocks) has commented on the proposal for Gtk2 Components::Gtk2_PHPConfig. Comment: Hi Anant, This is a nice application, but I have a few suggestions: - There are some notices thrown during use of the application. These should be cleaned up. Notice: Undefined index: Comments in /usr/share/pear/Gtk2/PHPConfig.php on line 310 Notice: Undefined variable: i in /usr/share/pear/Gtk2/PHPConfig.php on line 336 - There is no way to add a new extension. I can only overwrite the value of the current extension directive. - Add #!/usr/bin/php to run.phpw and give it a role="script". - I think it would be a good idea to break this class up into a base class (that uses Config) that parses and saves the ini file and also gets and sets the values. You could call it Config_PHPini. Then take all the GUI stuff and put in in a class called Config_PHPini_GUI_Gtk2. That way other people can come along and create different GUIs for the base package. Such as Config_PHPini_GUI_Web or Config_PHPini_GUI_CLI. Scott Mattocks Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=346 -- Sent by PEPr, the automatic proposal system at http://pear.php.net