Re: [PEPr] Comment on Gtk2 Components::Gtk2_PHPConfig

Hi Christian, > - The package file isn't valid. I get the following: Oops! I didn't use the package manager and didnt test my package file either. Sorry about that, I've fixed it now. > Since it's a GUI tool, it should provide some method to load a file via > GUI and not only via command line Ok, I had initially added a file->new and file->open menus, but scrapped it thinking that would make more of an application than a PEAR class. But, I'll restore those menus asap. > - The quit method should provide a way to cancel the closing process via > "Yes/No/Cancel" instead of yes/no only. Done. > - It would be nice if the ini structure could be kept, including all of > the comments. I personally hate it if I edit my config files with a > graphical tool, but loose all the comments I made by hand. I agree. I will make the Option description box editable and add that text as comments in the generated file asap. However, I'm not sure about retaining comments in existing files. Parsing is already slow! I will look into how I can implement that. Worst case, I will include those comments also at the cost of speed. > - Don't hard-code the "NEW" file name but use a constant. Better use NULL, > as a file may be named "NEW" Done. > - I don't know where DomDocument looks for files, but it seems to me as if > it's only the current working directory. Use dirname(__FILE__) to determine > the file directory. This was a point hounding me. The file is a sort of dependency for the package, where should the xml file be? Along with the class, or along with the example? I have used the dirname() function assuming that the xml file will be in the same directory as the class file. And as always, Thanks! :) Regards, -- Anant Narayanan ------------------------- Find Freedom! http://www.kix.in/