Re: R: [PEAR-DEV] Re: R: [PEAR-DEV] [PEPr] +1 for HTML::HTML_QuickForm_Livesearch
| From: | Mark Wiesemann | Date: | Mon, 13 Feb 2006 10:14:12 +0000 |
| Subject: | Re: R: [PEAR-DEV] Re: R: [PEAR-DEV] [PEPr] +1 for HTML::HTML_QuickForm_Livesearch | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41321@lists.php.net to get a copy of this message | ||
Giuseppe Dessì wrote:
> Corrected package structure.
> New file (as my last mail)
>
> http://clansworld.fastgaming.it/PEAR/QuickForm_Livesearch/HTML_QuickForm_Livesearch-0.0.2.tgzî×͵’É
> ôI|—]œ
(link repaired)
Just three remarks:
- Coding Standards: looks much better (but I did not look at every
single line of code)
- your class has the name HTML_QuickForm_LiveSearch_Select, this would
lead into HTML/QuickForm/LiveSearch/Select.php ('_' => '/'); you should
either change the class name or the install path in package.xml (upper
or lower case for the first letter shouldn't be a problem, QF itself
uses both cases)
- you could make the stylesheet configurable, e.g. via
$_GLOBALS['_QF_LIVE_SEARCH']['STYLESHEET'] or something like that, and
only if it isn't set, use your default stylesheet
Apart from that, I'm looking forward to the first release ...
Regards,
Mark