Re: Re: cvs: pear /PEAR_Command_Packaging/tests/make-rpm-spec test1.outtest1.phpttest_option_rpm-depname.out
test_option_rpm-depname.phpt test_option_rpm-pkgname.outtest_option_rpm-pkgname.phpttest_option_rpm-release.out test_option_rpm-re
| From: | Stefano F. Rausch | Date: | Fri, 17 Feb 2006 20:01:53 +0000 |
| Subject: | Re: Re: cvs: pear /PEAR_Command_Packaging/tests/make-rpm-spec test1.outtest1.phpttest_option_rpm-depname.out test_option_rpm-depname.phpt test_option_rpm-pkgname.outtest_option_rpm-pkgname.phpttest_option_rpm-release.out test_option_rpm-re |
||
| References: | 1 2 3 4 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41370@lists.php.net to get a copy of this message | ||
Isn't this the way PHPUnit2 structures the tests Greg? IMHO this should be the standard for PHP5 packages.
-- Stefano
Greg Beaver wrote:
Justin Patrin wrote:This is exactly what I said. Dependencies for a package should be *only* what you need for the package to run. If the tests introduce extra dependencies then that should be noted in the tests (perhaps in a README in the tests dir) but never add dependencies to the package. It *could* be a solution to make them optional dependencies but I don't much like this either as it could easily be construed that the package itself is able to use this optional dependency when this is not actually the case. One way to do this would be, if a package's tests require more/different dependencies than the package, to have a subpackage for the tests which includes the extra dependencies.I couldn't agree more with these assertions. Perhaps it might be worth officially noting in the manual that complex tests could (at the author's discretion) be located in a separate subpackage like Foo_Tests for package Foo? If this sounds interesting, I will see if I can work up a manual section on testing in the next 2 months. However, if someone wants to do this before me, I will be even more excited, so don't wait for me to commit if you have the spare time. Thanks, Greg