[PEPr] Comment on Database::MDB2_ActiveRecord
| From: | Lukas Smith | Date: | Fri, 10 Mar 2006 07:46:51 +0000 |
| Subject: | [PEPr] Comment on Database::MDB2_ActiveRecord | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41736@lists.php.net to get a copy of this message | ||
Lukas Smith (http://pear.php.net/user/lsmith) has commented on the proposal for
Database::MDB2_ActiveRecord.
Comment:
I have not really looked at the source deeply. You need to fix a lot of CS
issues. Especially the bracket placement and the extra whitespace between
the method name and the parenthesis.
I did look at your example and tweaked it slightly (CS fixes), using MDB2
to create the test table etc.
http://pooteeweet.org/pear/MDB2_ActiveRecord/test.phps
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=368
--
Sent by PEPr, the automatic proposal system at http://pear.php.net