[PEPr] Comment on Database::MDB2_ActiveRecord
| From: | Lukas Smith | Date: | Fri, 10 Mar 2006 08:14:01 +0000 |
| Subject: | [PEPr] Comment on Database::MDB2_ActiveRecord | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41737@lists.php.net to get a copy of this message | ||
Lukas Smith (http://pear.php.net/user/lsmith) has commented on the proposal for
Database::MDB2_ActiveRecord.
Comment:
Some more comments:
- using SELECT * is ugly IMHO, you should just list all of the relevant
columns; this could also make it easier to mask/hide columns or add
abstract columns (like CONCAT(..) ..)
- it seems all columns are passed to the update method, even those that
were not modified; this would make sense only if you would prepare the
query only once and reuse it, but you are using autoExecute() that
immediatly discards the prepared statement
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=368
--
Sent by PEPr, the automatic proposal system at http://pear.php.net