[PEPr] +1 for Gtk2 Components::Gtk2_EntryDialog
| From: | Martin Jansen | Date: | Thu, 16 Mar 2006 21:39:04 +0000 |
| Subject: | [PEPr] +1 for Gtk2 Components::Gtk2_EntryDialog | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41815@lists.php.net to get a copy of this message | ||
Martin Jansen (http://pear.php.net/user/mj) has voted +1 on the proposal for Gtk2
Components::Gtk2_EntryDialog.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=366
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=366&handle=mj
Comment:
I'm not using GTK, so I can't say much about the real use here. But the
code looks fine, which IMO warrants a +1.
Two minor points:
* The source code lacks the copyright header.
* I think that
$flags = ($parent === null ? 0 : Gtk::DIALOG_MODAL);
is much more readable than without the brackets.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net