[PEPr] Comment on PHP::PHP_CodeSniffer
| From: | Laurent Laville | Date: | Wed, 26 Jul 2006 07:36:03 +0000 |
| Subject: | [PEPr] Comment on PHP::PHP_CodeSniffer | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-43577@lists.php.net to get a copy of this message | ||
Laurent Laville (http://pear.php.net/user/farell) has commented on the proposal for
PHP::PHP_CodeSniffer.
Comment:
First, i would thanks Marc McIntyre for offline answer about file ending
line.
My problem on Windows platform and CR.
I don't have read carefully the PEAR docs (Coding Standard) :-)
Here is the link it can help to all other windows users, in case or.
http://pear.php.net/manual/en/standards.file.php
NOW, my new test attempt on a source file converted from windows CRLF to
unix LF.
CompatInfo.php
http://cvs.php.net/viewvc.cgi/pear/PHP_CompatInfo/CompatInfo.php?annotate=1.24
give me, i think a serious error that need to be fix, about line ident.
[LINE 181] ERROR: Line indented incorrectly. Expected atleast 93 spaces,
but found 20.
[LINE 185] ERROR: Line indented incorrectly. Expected atleast 93 spaces,
but found 24.
[LINE 186] ERROR: Line indented incorrectly. Expected atleast 93 spaces,
but found 20.
Same problem can be find later
[LINE 288] ERROR: Line indented incorrectly. Expected atleast 81 spaces,
but found 20.
[LINE 292] ERROR: Line indented incorrectly. Expected atleast 81 spaces,
but found 24.
[LINE 293] ERROR: Line indented incorrectly. Expected atleast 81 spaces,
but found 20.
Related to if-condition on two lines
Lines 179-180
Lines 286-287
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=426
--
Sent by PEPr, the automatic proposal system at http://pear.php.net