[PEPr] Comment on Web Services::Services_Nabaztag
| From: | Christian Weiske | Date: | Sat, 09 Dec 2006 09:01:50 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_Nabaztag | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-45134@lists.php.net to get a copy of this message | ||
Christian Weiske (http://pear.php.net/user/cweiske) has commented on the proposal for Web
Services::Services_Nabaztag.
Comment:
- The top level comments should not be indented
- Use protected - private is not necessary most times
- You don't handle errors when using "@file()" in apiRequest
- Make your debug information either XHTML compatible (<br/>), or better
use newlines so that it can be used on console, too.
Apart from this issues, I question the usefulness of the whole thing.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=463
--
Sent by PEPr, the automatic proposal system at http://pear.php.net