[PEPr] +1 for Web Services::Services_Nabaztag
| From: | Till Klampaeckel | Date: | Thu, 31 Jan 2008 23:01:34 +0000 |
| Subject: | [PEPr] +1 for Web Services::Services_Nabaztag | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49051@lists.php.net to get a copy of this message | ||
Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for Web
Services::Services_Nabaztag.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=463
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=463&handle=till
Comment:
This is great. And I think I need one. ;(
This vote is not conditional, but a few things I wanted to add (IMHO):
* get rid off dirname(__FILE__) in your code
* some of your if()'s seem pretty complicated (exit/return early where
possible)
* maybe more single quotes instead of double quotes
* there are a few PEAR CS things you should fix (through phpcs)
* your Exception class should extend PEAR_Exception
--
Sent by PEPr, the automatic proposal system at http://pear.php.net