RE: [PEAR-DEV] ISBN Proposal

Hi Tom! Tom Klingenberg wrote: > > hi list, > > just uploaded a draft ISBN php class that handles validation, > conversion > (that is just in time for 2007-01-01) and the parts of an > ISBN for ISBN-10 > and ISBN-13. please let me know what you think, wanted to put > this under > open source and pear was the first repository i thought about. > > so please keep in mind, that i'm completely new to all this > pear code > submission stuff. > > tom > A couple of things I noticed: - a direct link to the source code would be nice (i.e. to a phps file) - use single quotes (') instead of double quotes (") - write your own exception class that extends PEAR_Exception and throw that - IMHO most of the functionality provided by your package could go into Validate_ISPN; have you talked to the maintainers of Validate_ISPN? Cheers, Lukas