Re: ISBN Proposal

On Sun, 07 Jan 2007 20:05:17 +0100, Justin Patrin <papercrane@gmail.com> wrote:

On 1/5/07, Tom Klingenberg <tklingenberg@lastflood.net> wrote:

On Fri, 05 Jan 2007 15:57:52 +0100, Lukas Feiler <lukas@empoweredmail.com> wrote:

[...] please consider that double quotes will make your code run slower (mostly because of the variable parsing involved).

isn't that a myth? whatever i came from the single quote front and ended up double quoting finally. maybe its because it looks better?

No, it's not a myth. See http://pear.reversefold.com/strings/ IMHO single quotes is more readable, easier to debug, and easier to audit.

Hi Justin, thanks for your opinion and tips, this all makes much more sense then for me as well now. I made a new revision with all strings converted to single quotes and posted it. It includes an updated tools/codegen.html which now generates the code with single quotes. I performed an additional phpcs round on the file and went through the warnings this time. since you had so much information about the "how to quote" question, I'd like to ask for your opinion in another question as well: What is good practise in wrapping function defintions?

#302    private static function _ISBNBodyParts($isbnbody, &$registrationgroup,
#303                                           &$isbnsubbody)
#304    {

This is what I actually did in the file. You can take a look in the source: http://isbn.lastflood.com/__filesource/fsource_ISBN__ISBN.php.html#a302 The updated package: http://isbn.lastflood.com/ISBN-0.1.1.TGZ Checkout phpdoc docs here: http://isbn.lastflood.com/ So far, Tom