Re: ISBN Proposal

On Mon, 08 Jan 2007 23:42:41 +0100, Justin Patrin <papercrane@gmail.com> wrote:

I performed an additional phpcs round on the file and went through the warnings this time. since you had so much information about the "how to quote" question, I'd like to ask for your opinion in another question as well: What is good practise in wrapping function defintions?

 #302    private static function _ISBNBodyParts($isbnbody,

&$registrationgroup,

#303                                           &$isbnsubbody)
#304    {
 This is what I actually did in the file. You can take a look in the source:

http://isbn.lastflood.com/__filesource/fsource_ISBN__ISBN.php.html#a302 The updated package: http://isbn.lastflood.com/ISBN-0.1.1.TGZ Checkout phpdoc docs here: http://isbn.lastflood.com/ I suggest if you're wrapping one parameter, wrap them all. Spacing is good.

You mean something like this: # private static function _ISBNBodyParts( # $isbnbody, &$registrationgroup, &$isbnsubbody # ) # { Or all in the meaning of each: # private static function _ISBNBodyParts( $isbnbody,

#                                         &$registrationgroup,
#                                         &$isbnsubbody )

# { ? I think the second example looks better. but there is one problem. sometimes with optional parameters and their default value they tend to be longer than 65 chars anyway. -- tom