Re: Firebug driver for Log

On Wed, Feb 07, 2007 at 05:47:25PM +0200, Mika Tuupola wrote: > I wrote Firebug driver for Log. Most of the code is taken from win > and display drivers. It still need some polishing. Neat! > Source: > http://www.appelsiini.net/~tuupola/test/firebug.phps > http://www.appelsiini.net/~tuupola/test/firebug.txt I suggest moving the "print the buffer" code out of the destructor and into the close() method. The destructor should still call close(). This would make the behavior consistent with the other handlers. > Jon, Jan or Chuck: can this be included in Log package? I can commit > it in if needed. That sounds fine to me. Please also add a unit test and document the new handler and its configuration parameters in docs/guide.txt when you do so. -- Jon Parise (jon of php.net) :: The PHP Project (http://www.php.net/)