Re: Firebug driver for Log

On Wed, Feb 07, 2007 at 10:51:14PM +0200, Mika Tuupola wrote: > >I suggest moving the "print the buffer" code out of the destructor and > >into the close() method. The destructor should still call close(). > >This would make the behavior consistent with the other handlers. > > Done. I guess flush() should also be implemented? Ideally, yes, if it's appropriate for the handler. > >That sounds fine to me. Please also add a unit test and document the > >new handler and its configuration parameters in docs/guide.txt when > >you do so. > > Committed everything else but updated docs. I have to study the > documentation syntax a bit. @since tag needs to be changed before > relase. It should hopefully be pretty easy to pick up. The format is reStructuredText, and I use docutils to generate the final output formats. -- Jon Parise (jon of php.net) :: The PHP Project (http://www.php.net/)