Re: Firebug driver for Log

From: Date: Wed, 07 Feb 2007 20:51:14 +0000
Subject: Re: Firebug driver for Log
References: 1 2  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-45622@lists.php.net to get a copy of this message
On 7 Feb 2007, at 20:54, Jon Parise wrote:
I suggest moving the "print the buffer" code out of the destructor and into the close() method. The destructor should still call close(). This would make the behavior consistent with the other handlers.
Done. I guess flush() should also be implemented?
That sounds fine to me. Please also add a unit test and document the new handler and its configuration parameters in docs/guide.txt when you do so.
Committed everything else but updated docs. I have to study the documentation syntax a bit. @since tag needs to be changed before relase. And sorry, I added "*" into begining of commit message by habit. Maybe someone can edit CVS files to make messages consistent. --
Mika Tuupola                      http://www.appelsiini.net/~tuupola/


« previous php.pear.dev (#45622) next »