Re: Re: Services_ProjectHoneyPot

Hi Mark, On 4/29/07, Mark Wiesemann <wiesemann@php.net> wrote:

Hi Till, till wrote: I'd like to ask for feedback on my proposal for Services_ProjectHoneyPot. To be found here (includes php, phps, examples and inline docs): http://pear.php.net/pepr/pepr-proposal-show.php?id=480 Please step over to the "Proposal" phase. This will trigger an email to be sent to the pear-dev list and we can comment through the form on http://pear.php.net/pepr/pepr-comments-show.php?id=480. Some comments after a short look: - it's "PEAR", not "Pear" (e.g. in "Pear::isError()")

Fixed.

- please use 4 spaces and not more for indentation

Oh, yeah. ;-) ee uses 8. I'll fix that though.

- PEAR CS require a line-break before "{" only for functions and classes, but not for if statements

Is this a must or a recommendation?

- please read http://pear.php.net/pepr/pepr-proposal-show.php?id=419

Yeah, I've read this - I wasn't sure if that is a recommendation or a must-have. Also, Alexey stated that I shall not have a dep on PHP4 package. Cheers, Till