Re: Services_ProjectHoneyPot

Hi Till, till wrote: > I'd like to ask for feedback on my proposal for Services_ProjectHoneyPot. > > To be found here (includes php, phps, examples and inline docs): > http://pear.php.net/pepr/pepr-proposal-show.php?id=480 Please step over to the "Proposal" phase. This will trigger an email to be sent to the pear-dev list and we can comment through the form on http://pear.php.net/pepr/pepr-comments-show.php?id=480. Some comments after a short look: - it's "PEAR", not "Pear" (e.g. in "Pear::isError()") - please use 4 spaces and not more for indentation - PEAR CS require a line-break before "{" only for functions and classes, but not for if statements - please read http://pear.php.net/pepr/pepr-proposal-show.php?id=419 Regards, Mark -- http://www.markwiesemann.eu