Re: [Coding Standards] Loading all files at once

Matthew, >> I do not think that the impact is debatable at all to the "speed >> freak" faction. Modification of code at install time is not the way >> to go. It will cause all sorts of uncertainties during deployment > > Certainly, 15% is a sufficient enough gain to warrant making a change. > However, whether or not this should be the job of PEAR instead of a > build tool is debatable. Build tools are much better suited for this. We are not doing the job, we are giving the user a choice - a wider choice than we give them now. > If the 'pear package' command could create allfiles.php, a build tool > could then later strip out the require_once commands from the various > files. This would then suit those who want unzip-and-go (as allfiles.php > is present), those who want to keep it in the include_path (require_once > calls that utilize the include_path for resolution), and those who need > optimization (build tool to strip out *_once calls). If you use allfiles.php, you need to strip out all require_once calls - which isn't feasible for the unzip-and-go approach. Also, modifying files on installation is bad, because doing this, there will be dozens of different error sources, and bug tracking will begin with 'which installation options did you use?' because the installed files are not guranteed to look like the ones the developer uses to track down the bugs. Further, complicated things like conditional includes cannot just be stripped out from code while guranteeing that the code does not break. -- Regards/Mit freundlichen Grüßen Christian Weiske

Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc