[PEPr] Comment on Networking::AsteriskManager

Doug Bromley (http://pear.php.net/user/ashiro) has commented on the proposal for Networking::AsteriskManager. Comment: Thanks again! All great feedback. I've done most of the changes you've both mentioned except the following: Returning objectified data: I do plan on returning more programmatically defined data than simply text reponses form the Asterisk server. Unfortunately I've come across several problems with servers not returning standard output. This is inherent to Asterisk. This kind of relates to.... Sub-classing features: This is certainly something I'm going to look into. Whether I'll be able to build all of the sub-classes myself or simply put in the framework and let others do the sub-classes, I'm not sure. Although Asterisk can have many different combinations of features the Manager API command sremain similar. Its the Command method that is the most variable so it may be worth only sub-classing this. Or finding another way of dealing with it. Basically the developers released the Manager API with an array of commands but then decided to just allow any command they'd not specifically programmed in to be executed via the Command message. So how to treat this is something I'm going to look into. Separate Exception class: I'm always wary of creating separate exception classes for such a small class. I'll look into implementing if I expand and subclass the main features (or just the Command method). Is there a clear indicator of when you should create an exception class for your class? At a certain size, age, etc? Or should it just be done as a matter of course? Thanks again for the feedback - it's much appreciated. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=543 -- Sent by PEPr, the automatic proposal system at http://pear.php.net