Re: [PEPr] +1 for Networking::AsteriskManager

Hi Philippe and PEAR As promised I've created a seperate mail detailing the updates from your comments. Thanks for the great feedback - keep it coming! * You're absolutely right about the ping method. I've stopped it throwing an exception on fail and it now simply returns false if no pong received. * The $penalty parameter of the queueAdd() method now has a default of null. * I now check the startMonitor() method has succeeded and if it doesn't then an exception is thrown. Anything else don't hesitate to let me know. All the best. Doug Philippe Jausions wrote:

Philippe Jausions (http://pear.php.net/user/jausions) has voted +1 on the proposal for Networking::AsteriskManager. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=543 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=543&handle=jausions This vote is conditional. The condition is: I second Till conditional comments. - Otherwise, I wouldn't throw an exception for the ping() method, because non-response to a ping request is not an exception per-se for a method that's specifically called to check on the status. I think a "return false" would be more appropriate. (unless this is more of a keep-alive type of method, in which case "keepAlive()" would be a better name IMO.) - Shouldn't queueAdd()'s $penalty get a NULL as default value? - startMonitor() is not throwing an exception on non-"Success"

-- Essential Systems Ltd. 137 Golden Cross Lane Catshill Bromsgrove B61 7DY Tel: 0845 867 9002 DiD: 01527 557288 Fax: 01527 557271 Mob: 07943 233397