[PEPr] +1 for Networking::AsteriskManager
| From: | Philippe Jausions | Date: | Tue, 06 May 2008 14:49:09 +0000 |
| Subject: | [PEPr] +1 for Networking::AsteriskManager | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50031@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has voted +1 on the proposal for
Networking::AsteriskManager.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=543
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=543&handle=jausions
This vote is conditional. The condition is:
I second Till conditional comments.
- Otherwise, I wouldn't throw an exception for the ping() method, because non-response to a
ping request is not an exception per-se for a method that's specifically called to check on the
status. I think a "return false" would be more appropriate. (unless this is more of a
keep-alive type of method, in which case "keepAlive()" would be a better name IMO.)
- Shouldn't queueAdd()'s $penalty get a NULL as default value?
- startMonitor() is not throwing an exception on non-"Success"
--
Sent by PEPr, the automatic proposal system at http://pear.php.net