[PEPr] +1 for PHP::UML

From: Date: Wed, 30 Apr 2008 08:35:34 +0000
Subject: [PEPr] +1 for PHP::UML
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-49943@lists.php.net to get a copy of this message
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for PHP::UML. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=535 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=535&handle=cweiske This vote is conditional. The condition is: While the code itself looks good, you really need to work on the docblocks since most methods miss them. Your factory classes should be named PHP_UML_XMI_Factory_v1, not PHP_UML_XMI_Factory1 and *2 as they are now. This should also be reflected in the file layout. Constructs like <?php else throw new PHP_UML_Exception('File '.$filename.' does not exist.'); ?> are not allowed, you need {} around the block. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#49943) next »