RE: [PEAR-DEV] [PEPr] +1 for PHP::UML / Update

Hey all, First, thanks for the nice comments accompanying the votes. > This vote is conditional. So here's the change log: - Missing curly brace added - Classes PHP_UML_XMI_Factory, PHP_UML_XMI_Factory1, PHP_UML_XMI_Factory2 renamed in: PHP_UML_XMI_AbstractBuilder, PHP_UML_XMI_BuilderImpl1, PHP_UML_XMI_BuilderImpl2 (I think it's less ambiguous now) - Added an interface: PHP_UML_XMI_Builder - All methods are docblocked, except in PHP_UML_XMI_BuilderImpl1/2, whose methods are commented in the interface PHP_UML_XMI_Builder New release: https://sourceforge.net/project/showfiles.php?group_id=220394&package_id=268 554 Baptiste -----Original Message----- From: Christian Weiske [mailto:cweiske@php.net] Sent: mercredi 30 avril 2008 10:36 To: PEAR developer mailinglist Cc: Christian Weiske; Baptiste Autin Subject: [PEAR-DEV] [PEPr] +1 for PHP::UML Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for PHP::UML. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=535 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=535&handle=cweiske This vote is conditional. The condition is: While the code itself looks good, you really need to work on the docblocks since most methods miss them. Your factory classes should be named PHP_UML_XMI_Factory_v1, not PHP_UML_XMI_Factory1 and *2 as they are now. This should also be reflected in the file layout. Constructs like <?php else throw new PHP_UML_Exception('File '.$filename.' does not exist.'); ?> are not allowed, you need {} around the block. -- Sent by PEPr, the automatic proposal system at http://pear.php.net -- PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php