Re: [PEPr] +1 for PHP::UML

Hello Baptiste, > > Your factory classes should be named PHP_UML_XMI_Factory_v1, not > > PHP_UML_XMI_Factory1 and *2 as they are now. > According to which rule ? > But PHP_UML_XMI_Factory1 and PHP_UML_XMI_Factory2 belong to the same "level of > hierarchy". > They are two implementation classes of an abstract class (PHP_UML_XMI_Factory), > and I do consider that those three classes should belong to the same package. I thought the factory itself creates either Factory1 and Factory2 objects, but it seems I was wrong. If it's an abstract base class, it's ok -- Regards/Mit freundlichen Grüßen Christian Weiske