[PEPr] Changes in proposal for Payment::Payment_PayPalSoap
| From: | Michael Gauthier | Date: | Mon, 05 May 2008 13:27:16 +0000 |
| Subject: | [PEPr] Changes in proposal for Payment::Payment_PayPalSoap | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50011@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has edited the proposal for
Payment::Payment_PayPalSoap.
Change comment:
Address most of the feedback from Joe Stump:
1.) Consolidated exception class definitions in a single file.
2.) Made soapClient, soapHeader and soapOptions protected instead of
private.
5.) Wrap SoapFault in a package-specific exception class that extends a
base exception class for the package.
6.) Change package name to Payment_PayPal_Soap
7.) Lazily load the soap client when call() is run.
8.) Unit tests for PayPal's Express Checkout. The framework is in place to
easily add tests for other API sections. Also wrote an AllTests.php.
Additionally:
- PayPal responses that contain Error objects now throw an exception.
- updated package.php requirements to exclude versions of PHP with a
broken SOAP extension (PHP Bug #44882).
- documentation and typo fixes
Please review the proposal:
http://pear.php.net/pepr/pepr-proposal-show.php?id=556
--
Sent by PEPr, the automatic proposal system at http://pear.php.net