[PEPr] Comment on Payment::Payment_PayPalSoap
| From: | Michael Gauthier | Date: | Mon, 05 May 2008 13:34:50 +0000 |
| Subject: | [PEPr] Comment on Payment::Payment_PayPalSoap | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50012@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has commented on the proposal for
Payment::Payment_PayPalSoap.
Comment:
Joe, thanks for the in-depth feedback. I agree with and have addressed most
of your points in an update to the proposal. The two remaining points you
brought up are:
3.) I'm still not 100% happy with the way getters and setters are handled
in this class. I'd like to get this cleaned up before a vote.
4.) Initially, I used __call() instead of call(). I changed because
a.) __call() should be private and is then very difficult to document,
and
b.) __call() takes a variable number of arguments and we only want one
argument for PayPal requests. This means I have to validate the number of
arguments if I use __call().
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=556
--
Sent by PEPr, the automatic proposal system at http://pear.php.net