[PEPr] Comment on Payment::Payment_PayPalSoap

From: Date: Mon, 05 May 2008 15:42:27 +0000
Subject: [PEPr] Comment on Payment::Payment_PayPalSoap
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-50015@lists.php.net to get a copy of this message
Joe Stump (http://pear.php.net/user/jstump) has commented on the proposal for Payment::Payment_PayPalSoap. Comment: Michael, The updates are looking good. I'm still not a fan of private variables, but changing those at a future date to protected won't, technically, break BC so I've got time to sway you on that. :) 1.) You throw InvalidArgumentException in the client's constructor. I don't see this defined anywhere. I see references on the Googles to it being in SPL. Unsure what PEAR's stance on SPL is at this point. 2.) In call() I'd probably type hind $arguments as `array $arguments = array()`. Other than that everything looks good. Thanks! --Joe Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=556 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#50015) next »