[PEPr] Comment on Images::JpegXmpReader

Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for Images::JpegXmpReader. Comment: As Chuck noted, class name should be Image_JpegXmpReader or Image_JPEG_XmpReader. On failure return a package exception (for instance Image_JPEG_XmpReader_Exception (extends PEAR_Exception)) instead of FALSE. You can return FALSE if something was not found but is not a critical failure, and could be expected to not be found. Please run PHP_CodeSniffer on your code. PEAR uses a 4-space indentation for instance. The first line of docblock cannot be blank, etc... You don't need the class constructor if it only calls the parent::__construct() Put the declaration of all the members ($xml) in the head of the class, not the very bottom, that's where everybody expect them. You'll need to convert the package.xml into version 2.0 (there's a pear command line option for that) If you have examples include them as well. If I remember corretly, the first version cannot be 1.0.0+, it has to be something like 0.x.y (Double check PEAR manual though) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=560 -- Sent by PEPr, the automatic proposal system at http://pear.php.net