[PEPr] +1 for Event::Event_Dispatcher2
| From: | Daniel O'Connor | Date: | Sat, 23 May 2009 09:27:41 +0000 |
| Subject: | [PEPr] +1 for Event::Event_Dispatcher2 | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51848@lists.php.net to get a copy of this message | ||
Daniel O'Connor (http://pear.php.net/user/doconnor) has voted +1 on the proposal for
Event::Event_Dispatcher2.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=596
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=596&handle=doconnor
This vote is conditional. The condition is:
I'm for this package conceptually, but I don't like:
* Use of SimpleTest means that this package can't be easily integrated into the pear wide test
suite (Either phpunit or pear's run-tests are the options I like to push here)
* Code needs cleanup & PHPCS.
* The use of the 'final' keyword - if a unit test wants to mock out something out, you
are blocking it from happening.
* Encouraging singletons (if you only need one instance of an object, inject it; singleton makes
testing a PITA)