Re: [PEPr] Comment on Event::Event_Dispatcher2

Hey Dimitri, (I'm CC'ing pear-dev.) If your work is based on Event_Dispatcher than you have to use the BSD license unless the original maintainers agree to move their code to GPL(v3). I don't see why that would/should happen though. The GPL limits use of your code severely, you should look at least into the LGPL license. Cheers, Till On Sat, Apr 4, 2009 at 3:09 PM, Dmitri Snytkine <d.snytkine@gmail.com> wrote: > About the licence: In my own project I use GPL 3 > http://www.gnu.org/licenses/gpl-3.0.txt and I would like to > always use it > but this license was not available as one of the option in pear proposal. I > think pear should add GPL version 3 as one of the options. > > About simple-test: I am not very experienced with it. What is AllTests.php? > > I will do codeSniffer and include_once. > > > > On Sat, Apr 4, 2009 at 8:56 AM, Till Klampaeckel <till@php.net> wrote: >> >> I've looked at the code: >> http://dev.sharedlog.com/svn/trunk/Event/ >> >> A few pointers first off: >> 1) The license on the proposal says PHP License, but in the code it's the >> BSD License. Which one is it? :) >> >> 2) phpcs (PHP_CodeSniffer) should be run on the code (to conform to basic >> PEAR CS). >> >> 3) require_once inside class-code is not a good idea, especially when you >> can override the class name? Use class_exists() and include_once instead, >> etc.. >> >> 4) Can you integrate SimpleTest using an AllTests.php file? >> >> -- >> http://pear.php.net/pepr/pepr-proposal-show.php?id=596 > >