[PEPr] Comment on Event::Event_Dispatcher2
| From: | Till Klampaeckel | Date: | Sat, 04 Apr 2009 12:56:47 +0000 |
| Subject: | [PEPr] Comment on Event::Event_Dispatcher2 | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51708@lists.php.net to get a copy of this message | ||
I've looked at the code:
http://dev.sharedlog.com/svn/trunk/Event/
A few pointers first off:
1) The license on the proposal says PHP License, but in the code it's the
BSD License. Which one is it? :)
2) phpcs (PHP_CodeSniffer) should be run on the code (to conform to basic
PEAR CS).
3) require_once inside class-code is not a good idea, especially when you
can override the class name? Use class_exists() and include_once instead,
etc..
4) Can you integrate SimpleTest using an AllTests.php file?
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=596