[PEPr] Comment on Networking::Net_I2C

From: Date: Sun, 09 Aug 2009 17:41:56 +0000
Subject: [PEPr] Comment on Networking::Net_I2C
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-52595@lists.php.net to get a copy of this message
- Agreed with Christian, comments and error messages should be in English (unfortunately for some, this is the de-facto standard language) - Net_IP2Country would be a better self-explanatory name - I'd suggest to do 2 separate classes for back end SOAP vs. HTTP. Net_IP2Country_SOAP and Net_IP2Country_HTTP, with a Net_IP2Country::factory($backend) method. Your code will be much cleaner instead of having hooks for methods to use, and that would also allow for extensions (interfacing with a MaxMind's GeoIP local database for instance) - fopen(URL) may not always be allowed on a system, use HTTP_Request2 package instead -- http://pear.php.net/pepr/pepr-proposal-show.php?id=608

« previous php.pear.dev (#52595) next »