[PEPr] Comment on Networking::Net_I2C
| From: | Michael Gauthier | Date: | Mon, 10 Aug 2009 17:44:10 +0000 |
| Subject: | [PEPr] Comment on Networking::Net_I2C | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-52605@lists.php.net to get a copy of this message | ||
Great start. Christian and Philippe have provided some excellent feedback
so far. Here are some suggestions:
1.) Rather than both a SOAP and HTTP implementation, I'd suggest just
choosing one. The external API shouldn't care what the internal code is
using.
2.) Maybe categorize the package in the Web Services category. This seems
like a wrapper for a Web service rather than a networking component. Maybe
Services_GeoIP
3.) Consider a factory method for other geolocation providers. Something
like Services_ShortURL
(http://pear.php.net/pepr/pepr-proposal-show.php?id=598). I think Google
also provides a geolocation service.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=608