Re: [PEPr] Call for votes on Web Services::Services_IP2Country

Samuel ROZE a écrit :

Samuel ROZE (http://pear.php.net/user/rozesamuel) has initiated the call for votes on Web Services::Services_IP2Country. Please review the proposal and give your vote here: http://pear.php.net/pepr/pepr-proposal-show.php?id=608

Hi Samuel, Before the vote I'd like to add some comments to the excellent ones you got. (I'm commenting here cause now comments are closed.) The tarball gives a 404, so I'll speak about the code here: http://tasks.d-sites.com/repositories/browse/librairies/Services_IP2Country 1. the service URL (http://i2c.mes-stats.fr/get?ip=) seems to be provided/hosted by you, am I right ? do you think it will be something "durable", I mean will you host the service as long as you can ? It would be too bad if the service was down 3 monthes later; 2. your package layout should be something like: docs/

    |_ README
    |_ LICENSE

examples/

    |_ uses.php

tests/ Services/

    |_ IP2Country.php
    |_ IP2Country/
        |_ Exception.php
        |_ Transport.php (some Services_IP2Country_Transport interface or abstract class)
        |_ Transport/
            |_ HTTP.php (class Services_IP2Country_Transport_HTTP)
            |_ SOAP.php (class Services_IP2Country_Transport_SOAP)

package.xml (Currently you have all the code in the same directory and there is no package.xml.); 3. speaking of Transports, beware, not everybody has "allow_url_fopen" enabled, maybe you could throw an exception explaining this, or use HTTP_Request2 as a dependency; 4. you should provide some unit tests (this can come later but it would be great if you provided some quickly). Code is very clean otherwise. -- David