Re: BC breaks: Cache_Lite, PHP_Documentor

Hi Daniel, On 31.08.2010 18:29, Daniel O'Connor wrote:

What exactly are you trying to achieve here? The error messages are run time, not compile time, so they will only affect those running with deprecated magic quotes enabled *and* not having E_DEPRECATED messages switched off.

I think a better approach is to allow such people see the error messages (and possibly fix their setup at last) rather than silently break the packages for them (PEAR_Error is quite easily missed).

Re what I'm trying to achieve: http://ollehost.dk/media/pear-bugs/< make the counter shrink :D Alright; so we've got a few different points of view available; and the ini_set() / ini_get is probably the best outcome for changing the code.

I'd wager a few kopecks that ini_set('magic_quotes_runtime', ...) will throw E_DEPRECATED, too.

I'm a bit reluctant to leave as is for too long (read: years) - both packages are fairly popular, and if PHP 5.4/6 kills off the methods; the migration path for a heck of a lot of other users is much more painful (Cache_Lite -> Zend_Cache, PHPDocumentor -> ... doxygen?).

You are missing my point again: the migration path for users is to stop relying on magic_quotes_runtime and switch it off. The migration path for packages is to quit calling set_magic_quotes_runtime() unconditionally (I now see that phpDocumentor does that): this will prevent errors for people who are not relying on deprecated functionality.