Re: Re: Waiting for you?
| From: | afshin.meh@gmail.com | Date: | Tue, 08 Feb 2011 08:47:38 +0000 |
| Subject: | Re: Re: Waiting for you? | ||
| References: | 1 2 3 4 5 6 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54076@lists.php.net to get a copy of this message | ||
Hi dear Christian,
Thanks for your response.
Should I fix this problems and upload my patch again?
Sincerely yours.
On Tue, Feb 8, 2011 at 12:13 PM, Christian Weiske <cweiske@cweiske.de>wrote:
> Hi Afshin,
>
>
> > Now i upload new real patch.
> > Sincerely yours.
>
>
> http://pear.php.net/bugs/bug.php?id=18157&edit=12&patch=fix-root-home&revision=1297157950
>
> Two things:
> - You did not follow the PEAR Coding Standards with i.e. "}else{".
> Please run PHP_CodeSniffer on the code after you patched it.
> - The assignment of $strUser to $strHome is unnecessary since
> the username is known. Not using the variable will save
> code execution time:
> if($strUser == "root"){ $strHome = '/' . $strUser;
> -> $strHome = '/root';
> - You added another empty line further down that is not necessary.
> Please keep the patches minimal and without changes that do not
> belong into them.
>
> --
> Regards/Mit freundlichen Grüßen
> Christian Weiske
>
> -= Geeking around in the name of science since 1982 =-
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>