Re: Re: Waiting for you?

Hello Christian, This is my patch after running and fixing: # It uses platform neutral UTF-8 encoding and \n newlines. # Above lines and this line are ignored by the patching process. Index: Folders.php --- Folders.php Remotely Modified (Based On HEAD) +++ Folders.php Locally Modified (Based On LOCAL) @@ -515,9 +515,13 @@ //env not set, so try the default directory $strUser = $this->getUserName(); if ($strUser !== null) { + if ($strUser == "root") { + $strHome = '/root'; + } else { $strHome = '/home/' . $strUser; } } + } } else if ($this->sys == SYS_MAC) { if (isset($_ENV['HOME'])) { //environment variable set If this is true, please say me to upload this patch. Thanks. Sincerely yours. On Tue, Feb 8, 2011 at 12:43 PM, Christian Weiske <cweiske@cweiske.de>wrote: > Hello Afshin, > > > > > > > Thanks for your response. > > > > Should I fix this problems and upload my patch again? > > > Yes, that's the best way. > > Ok, sure. > > > > http://pear.php.net/bugs/bug.php?id=18157&edit=12&patch=fix-root-home&revision=1297159694 > > @@ -515,9 +515,13 @@ > //env not set, so try the default directory > $strUser = $this->getUserName(); > if ($strUser !== null) { > + if($strUser == "root"){ > + $strHome = '/root'; > + } else { > $strHome = '/home/' . $strUser; > } > } > + } > } else if ($this->sys == SYS_MAC) { > if (isset($_ENV['HOME'])) { > //environment variable set > > Did you really run the codesniffer on the code after you changed it? I > doubt that. > > -- > Regards/Mit freundlichen Grüßen > Christian Weiske > > -= Geeking around in the name of science since 1982 =- > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >