Re: Re: Waiting for you?
| From: | Christian Weiske | Date: | Tue, 08 Feb 2011 09:45:12 +0000 |
| Subject: | Re: Re: Waiting for you? | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54080@lists.php.net to get a copy of this message | ||
Hello Afshin,
> This is my patch after running and fixing:
>
> --- Folders.php Remotely Modified (Based On HEAD)
> +++ Folders.php Locally Modified (Based On LOCAL)
> @@ -515,9 +515,13 @@
> //env not set, so try the default directory
> $strUser = $this->getUserName();
> if ($strUser !== null) {
> + if ($strUser == "root") {
> + $strHome = '/root';
> + } else {
> $strHome = '/home/' . $strUser;
> }
> }
> + }
> } else if ($this->sys == SYS_MAC) {
This is actually not correct since you break indentation levels after
the else line. please install php_codesniffer; its easy:
$ pear install php_codesniffer
$ phpcs Folders.php
Your patch would need to look as follows:
> //env not set, so try the default directory
> $strUser = $this->getUserName();
> if ($strUser !== null) {
> - $strHome = '/home/' . $strUser;
> + if ($strUser == "root") {
> + $strHome = '/root';
> + } else {
> + $strHome = '/home/' . $strUser;
> + }
> }
> }
> } else if ($this->sys == SYS_MAC) {
--
Regards/Mit freundlichen Grüßen
Christian Weiske
-= Geeking around in the name of science since 1982 =-