Re: Support for OpenDocument packages

Hello Olivier, > > So the base class (haven't looked at the code yet) gets methods for > > file manipulation added? > Not really. It's just loading a file from the Zip/Package, unless it's > an Office document, in which case it's back the the previous > behaviour. I looked at the code and improved your patch a bit; see my cloned repository. > > "files" is an instance of some file manager class that gets passed > > the zip. "files" is also a bad name, maybe "filemanager" or > > something more appropriate. I just saw that the class is already a zip-specific storage, so that "filemanager" would be completely useless. What's your stand regarding unit tests? I think the best would be to convert the existing tests to PHPUnit and begin adding tests for the changed functionality then. Btw, what do you think about moving the discussion to pear-dev? Maybe others chime in, and it's at least a sign of activity. -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=-

Attachment: [application/pgp-signature] signature.asc