Re: Support for OpenDocument packages

Le mercredi 16 mars 2011 à 08:36 +0100, Christian Weiske a écrit : > Hello Olivier, > > > > > So the base class (haven't looked at the code yet) gets methods for > > > file manipulation added? > > Not really. It's just loading a file from the Zip/Package, unless it's > > an Office document, in which case it's back the the previous > > behaviour. > I looked at the code and improved your patch a bit; see my cloned > repository. > I've only seen the change in 2 commits on the master branch. Have you also reviewed the 'packages' branch ? It contains much more changes ;) > > > > "files" is an instance of some file manager class that gets passed > > > the zip. "files" is also a bad name, maybe "filemanager" or > > > something more appropriate. > I just saw that the class is already a zip-specific storage, so that > "filemanager" would be completely useless. > > What's your stand regarding unit tests? I think the best would be to > convert the existing tests to PHPUnit and begin adding tests for the > changed functionality then. I don't know... maybe the current PEAR-like tests are sufficient. I have some work pending on PHPUnit too (its packaging in Debian that needs love), FYI... but I'm not sure I'll have much time to rethink tests, given the huge backlog already pending :-/ > > Btw, what do you think about moving the discussion to pear-dev? Maybe > others chime in, and it's at least a sign of activity. > That could be possible... I'll try and subscribe. Best regards, P.S.: I had integrated some of your latest changes in the 'packages' branch already. -- Olivier BERGER <olivier.berger@it-sudparis.eu> http://www-public.it-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8 Ingénieur Recherche - Dept INF Institut TELECOM, SudParis (http://www.it-sudparis.eu/), Evry (France)