Re: Support for OpenDocument packages

Le mardi 22 mars 2011 à 09:34 +0100, Christian Weiske a écrit : > Hello Olivier, > I had finally the time to review your changes. Here are some comments: > - You put several classes in one file, i.e. OpenDocumentPackage_Storage > and OpenDocument_Storage. PEAR follows the one-file-per-class rule > which e.g. makes autoloading trivial - this rule is broken here > - You sometimes do whitespace changes that just break the PEAR Coding > Styles and do nothing else. > - Apart from that two issues do I like the idea to have base classes > that only care about the base file+manifest handling and implement > the office document specific things on a layer above them. What I > don't like is the class naming; I'll change that. > I think it will be along > - OpenDocument_Base_Document > - OpenDocument_Base_Storage > - OpenDocument_Base_Storage_Zip As you see fit. It was more or less a quick & dirty implementations solving my immediates needs. Glad it boosts your motivation to improve it :-) Hope you like it mostly ;) Tell me when you have committed a new version. Thanks in advance. Best regards, -- Olivier BERGER <olivier.berger@it-sudparis.eu> http://www-public.it-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8 Ingénieur Recherche - Dept INF Institut TELECOM, SudParis (http://www.it-sudparis.eu/), Evry (France)