[PEPr] +1 for Web Services::PageRank
| From: | Michael Gauthier | Date: | Tue, 14 Feb 2012 17:15:05 +0000 |
| Subject: | [PEPr] +1 for Web Services::PageRank | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54808@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for Web
Services::PageRank.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=666
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=666&handle=gauthierm
Comment:
Looks good. I have a couple of questions and comments:
1.) Your license blocks still have <ORGANIZATION> in them. Should be set to
you or your company.
2.) Consider the subject-observer pattern for logging rather than providing
an empty log method. See http://www.php.net/manual/en/class.splsubject.php
3.) What legitimate uses does this have? The code says right in it "Mining
PageRank is AGAINST GOOGLE'S TERMS OF SERVICE. Yes, I'm talking to you,
scammer." You should outline the legitimate uses in the package description
and make it clear what the illegitimate uses are.