Re: [PEPr] +1 for Web Services::PageRank

On Wed, Feb 15, 2012 at 8:12 PM, HM 2K <nfhm2k@gmail.com> wrote: > Hi Ken, > > Can you advise what further tests you think I should add? > I'd suggest adding tests for checking how Services_PageRank should behave when/if there are connectivity issues, unexpected responses and so on. > Also, I choose to ignore the phpcs warnings with regards to line length as > I believe it doesn't improve anything. > > It improves readability, and when you're providing an open source project it's hard to predict what editors, IDEs and habits people have. I like to view code in vertically split windows - doing this with PageRank.php does require some level of horizontal scrolling. And if someone decides they need a hard-copy (printout) of your code staying inside the 80 character line length requirement will mean none of the code gets truncated on paper. Ken > On Sat, Feb 11, 2012 at 11:42 AM, Ken Guest <ken@linux.ie> wrote: > >> Ken Guest (http://pear.php.net/user/kguest) has voted +1 on the proposal >> for Web Services::PageRank. >> >> Proposal information: >> http://pear.php.net/pepr/pepr-proposal-show.php?id=666 >> Vote information: >> >> http://pear.php.net/pepr/pepr-vote-show.php?id=666&handle=kguest >> >> Comment: >> >> This is not a conditional vote but: >> I'd like to see better code coverage in the tests - coverage is currently >> at some 70%. >> Also there are a few warnings emitted by php_codesniffer as regards >> line-length and some lines with trailing spaces which should be cleaned up >> IMHO. >> >> Small stuff really. >> > > -- http://blogs.linux.ie/kenguest/