Re: Problems w/ "pear install <URL>"

On Mon, 2002-04-29 at 03:16, Tomas V.V.Cox wrote: > "Stig S. Bakken" wrote: > > > > On Wed, 2002-04-24 at 00:50, Tomas V.V.Cox wrote: > > > "Jesus M. Castagnetto" wrote: > > > > > > > > > > > > I changed package.xml to read: > > > > > > > > <dir name="test" role="data"> > > > > <file role="php">testChem.php</file> > > > > <file role="php">testPDB.php</file> > > > > <file role="php">xyz2cml.php</file> > > > > <file role="data">1hca.pdb</file> > > > > <file role="data">his.pdb</file> > > > > <file role="data">his.xyz</file> > > > > <file role="data">lys.pdb</file> > > > > <file role="data">lys.xyz</file> > > > > <file role="data">small.pdb</file> > > > > <file role="data">water.cml</file> > > > > </dir> > > > > > > > > But still, no .xyz, .pdb or .cml in Science/Chemistry/test, after trying: > > > > > > > > pear upgrade > > > > http://pear.php.net/get/Science_Chemistry > > > > > > > > Just to be sure I did an uninstall (also removed manually the Science dir and > > > > check the .registry dir too) and then a clean install, and still the files are > > > > missing. I did see that in the latest PEAR/Installer.php there are the > > > > following lines: > > > > ... > > > > switch ($atts['role']) { > > > > case 'test': case 'data': case 'ext': > > > > // don't install test files for now > > > > $this->log(2, "$file: $atts[role] file not installed > > > > yet"); > > > > return true; > > > > > > > > so a 'role="data"' will not work, using an older version of > > > > PEAR/Installer.php, > > > > (i.e. the one bundled w/ PHP 4.1.2) it will work, because the logic is > > > > different. > > > > > > Ah ok, I missed that change. +1 for getting back "data" to the installed > > > files. Stig? > > > > Agreed. But where? We're already using autoconf's $datadir as include > > root (PREFIX/share/pear). Maybe we should append "-data" to $datadir so > > data files end up in PREFIX/share/pear-data? > > > > I'd vote to have them installed under PEAR_INSTALL_DIR. Just because > they can be manipulated directly from the class with fopen($file, 'r', > true);. I guess that these files don't disturb too much there. There are a few classes that actually peek around there (the installer does, many of the factory classes do), so I'd rather have it separate from the code. A compromise could be PEAR_INSTALL_DIR/data. - Stig