Re: HTML_Form orphaned. Major fixup made.
| From: | David Costa | Date: | Sat, 29 May 2004 16:40:34 +0000 |
| Subject: | Re: HTML_Form orphaned. Major fixup made. | ||
| References: | 1 2 3 4 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-1281@lists.php.net to get a copy of this message | ||
On May 29, 2004, at 6:26 AM, Daniel Convissor wrote:
Hi David, et al: On Sat, May 29, 2004 at 12:35:39AM +0200, David Costa wrote:Daniel, to clarify, I have no doubt on your qualities as a PHP coder and PEAR developer. In fact I value very much each of your contributions. That said, I am sure you understand my point. For my package it wasn't a big issue as you did modified the tabs only. The issue is not knowing what is going on in your package tree and this occurs only if we start committing on packages where we are not leads or developers. I am well aware of the issues with HTML_Form but a discussion on this list before committing would have been the right way to proceed. I discussed very briefly the matter with Stig on IRC (this was around 1 month ago) and he just said that HTML_Quickform is the way to go. This is why my opinion was, after a discussion on QA and the relevant approvals, to consider the removal of HTML_Form from the public directory and release only QA updates (as you probably already did). In short, the rule of not committing in other trees is valid for everyone, me, you, Group members etc. You are the lead of one of the major PEAR package and I am sure that you will be more then willing to set the good example for new developers. Too late now, but you should not commit again in a tree beside your own unless you receive an approval from the lead. It is true that on my numbers_roman package my email (php.net in fact) was slow/down but you didn't wait my approval to commit. The same stands for HTML_Form and every other package. As you can see both me and others waited to be assigned as lead in a package before doing the necessary fixes/upgrades. Thanks in advance for your time and understanding, Regards David CostaCommitting on someone else tree it's a no no.Granted. A few minutes ago I sent an email to Stig apologizing for not asking him first. (I also apologize for committing to the roman numbers package you were working on. Then, like now, I got impatient. Back then it seemed you misunderstood what I was saying and the communication was hindered by your server rejecting emails from php.net.)
And really there was nothing THAT critical on this package beside the 3 bugs.There were a LOT more problems than that. http://cvs.php.net/co.php/pear/HTML_Form/package.xml Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Ydata intensive web and database programming http://www.AnalysisAndSolutions.com/4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409 -- PEAR QA Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php