RE: [PEAR-CVS] cvs: pear /DB/DB dbase.php fbsql.php ibase.php ifx.php msql.php mssql.php mysql.php mysql4.php oci8.php odbc.php pgsql.php sqlite.php
sybase.php

> From: Pierre-Alain Joye [mailto:paj@pearfr.org] > Sent: Friday, January 02, 2004 2:42 AM > On Fri, 2 Jan 2004 02:04:35 +0100 > "Lukas Smith" <smith@backendmedia.com> wrote: > > > > Of course it changes things. > > However it only does when you use the portability option. There any > > differences in behaviour between the drivers should be considered a > > bug and this patch fixes it. > > Imagine someone using mysql, uppercases columnnames and portability > flags, what happen with this change? Well "portability" mode is not the default. So everybody who is using portability mode specifically made the decision to use that mode because he was looking for portability. Then again you could argue he was just looking for the specific thing that portability mode did in the driver he was using. IIRC portability mode did 3 different things in the various drivers: 1) lowercase string keys in result arrays in the ibase, odbc and oracle driver 2) add numRows hack in the oracle driver 3) add affectedRows hack in the mysql, fbsql and sqlite driver I would assume that any ibase, odbc and oracle user would appreciate the change. Users of mysql, fbsql and sqlite driver may run into issues of they used the portability mode to get their affectedRows results fixed. I don't think that this will be a significant amount compared to the people that will run into surprises if they find out that portability mode means that cases are only change in some and not all drivers. As far as I know there is no documentation of this feature. However I find the name of the options and its values quite verbose and therefore I think its safe to consider this a bug fix and not a BC break. However if people prefer to add yet another option then this is also possible. In that case I would leave the changes and add an option to get the old behaviour. Regards, Lukas