Re: cvs: pear /DB/DB dbase.php fbsql.php ibase.php ifx.php msql.php mssql.php mysql.php mysql4.php oci8.php odbc.php pgsql.php sqlite.php sybase.php

For options['optimize'] - modify setOption to assign options['portability'] to use 'all options' (basically works like E_ALL) The reason for modifying tableInfo, is that A) oracle already does this. B) dataobjects currently uses this to get the column names, I would guess that if you want portability, and use tableInfo, then it should resemble the database results.. I think we can also add a bigger docbook note to setOption to describe the various options in detail.

Sounds like he is proposing a magic free quote() for this. I prefer the path of adding a smartQuote() which has all the magic, and leave the current quote() magic (1.5.RC2) in there.

While I would have prefered to change quote to smartQuote, it seems a bit late now, quote already had alot of features for seletively quoting, the fixes so far, really just make that behaviour consistant. the idea of simpleQuote is to quote and escape whatever input it gets, whatever the type the variable is.. (it would make the code in quoteString a bit simpler as well... Regards Alan

Regards, Lukas

-- Can you help out? Need Consulting Services or Know of a Job? http://www.akbkhome.com