RE: [PEAR-CVS] cvs: pear /DB/DB dbase.php fbsql.php ibase.php ifx.php msql.php mssql.php mysql.php mysql4.php oci8.php odbc.php pgsql.php sqlite.php
sybase.php

> From: Daniel Convissor [mailto:danielc@analysisandsolutions.com] > Sent: Friday, January 02, 2004 11:52 PM > To: Lukas Smith > Cc: 'Pierre-Alain Joye'; alan@akbkhome.com; danielc@php.net; pear- > cvs@lists.php.net; 'pear-qa' > Subject: Re: [PEAR-CVS] cvs: pear /DB/DB dbase.php fbsql.php ibase.php > ifx.php msql.php mssql.php mysql.php mysql4.php oci8.php odbc.php > pgsql.php sqlite.php sybase.php > > On Fri, Jan 02, 2004 at 02:53:01AM +0100, Lukas Smith wrote: > > I would assume that any ibase, odbc and oracle user would appreciate the > > change. > > Just to emphasize... This is why I put it in there. People who initially > designed their applications on these DBMS's with portability on expect the > keys to be in lower case, so would expect the same behavior when moving to > a different database type. Ok since these are long standing "bugs" and since not everybody actually cares about portability across all supported RDBMS and to generally reduce the risk of having users coming after us I suggest we take the following compromise: - 'portability' will remain as it is now (lowercasing across all drivers), maybe evening adding the rtrim call (I think in MDB the ibase driver does that too) - add an option to get the old behaviour - add a smartquote() - remove magic stuff from quote() - add an option to keep the old magic in quote() This means we add two BC options. Adding an option like "lowerkeys" doesn't make sense since I would expect portability features to be enabled with the "optimize" for "portability" option. Regards, Lukas